Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomposedfs lookup outermost root #2373

Closed
wants to merge 32 commits into from

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Dec 13, 2021

When stating a resource by id the decomposedfs will now also return the outermost space root. This allows the gateway to properly reconstruct global paths by combining the space mountpoint and the relative path.
For the owner the root will be the space root, For share recipiens the root will be the outermost shared resource. For now, the root is returned as an opaque property.

@butonic butonic force-pushed the decomposedfs-lookup-outermost-root branch from 106affc to 0060846 Compare December 13, 2021 15:11
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the decomposedfs-lookup-outermost-root branch from 5e28dc9 to 743e7a3 Compare December 15, 2021 16:24
@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2021

This pull request introduces 1 alert when merging 743e7a3 into 5dde0ef - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the decomposedfs-lookup-outermost-root branch from 56be50c to 99da3c0 Compare December 15, 2021 20:37
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
// but that might be the personal space of another user where the current user has no access
// so we need to take the "root" in the opaque and find its mount point for the current user
// what is the root to which the path of the statResp is relative?
rootId := &provider.ResourceId{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var rootId should be rootID

// but that might be the personal space of another user where the current user has no access
// so we need to take the "root" in the opaque and find its mount point for the current user
// what is the root to which the path of the statResp is relative?
rootId := &provider.ResourceId{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var rootId should be rootID

// but that might be the personal space of another user where the current user has no access
// so we need to take the "root" in the opaque and find its mount point for the current user
// what is the root to which the path of the statResp is relative?
rootId := &provider.ResourceId{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var rootId should be rootID

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the decomposedfs-lookup-outermost-root branch from 8b52ca4 to b6ca718 Compare December 20, 2021 16:43
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic mentioned this pull request Dec 21, 2021
1 task
@butonic
Copy link
Contributor Author

butonic commented Jan 12, 2022

Closed in favor of making the gateway dumb again by moving the space lookup logic to clients, when the ocdav handler is one of them.

@butonic butonic closed this Jan 12, 2022
@butonic butonic deleted the decomposedfs-lookup-outermost-root branch January 12, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant