-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references when declining shares #1991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
force-pushed
the
remove-reference
branch
from
August 13, 2021 13:31
7c8814b
to
698dd2b
Compare
refs
reviewed
Sep 2, 2021
C0rby
force-pushed
the
remove-reference
branch
4 times, most recently
from
September 2, 2021 16:37
2dadaba
to
8358b4e
Compare
butonic
previously approved these changes
Sep 3, 2021
refs
requested changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a remark that I would like clarified before merging, but conceptually 👍 LGTM
refs
previously approved these changes
Sep 3, 2021
C0rby
force-pushed
the
remove-reference
branch
2 times, most recently
from
September 7, 2021 16:31
98875bc
to
51d1712
Compare
C0rby
force-pushed
the
remove-reference
branch
from
September 7, 2021 16:52
51d1712
to
4a1750b
Compare
labkode
approved these changes
Sep 8, 2021
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the removal of share references when a share gets declined.
Now when a user declines a share it will no longer be listed in their
Shares
directory.