Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method to remove references to the storageprovider api #141

Closed
wants to merge 1 commit into from

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Aug 13, 2021

Add a new method to the storage provider to be able to remove references.
This is helpful when a user declines a share, since we only want to remove the reference to the shared file but not the file itself.

Once merged cs3org/reva#1991 would make use of this change.

@C0rby C0rby requested a review from labkode as a code owner August 13, 2021 14:15
@labkode
Copy link
Member

labkode commented Sep 2, 2021

Hey @C0rby. A reference is just like a symbolic link and can be removed with the Remove operation.
When a share gets accepted, a new reference is created. When a share is declined the reference is removed with Remove operation. That is my understanding.

@refs
Copy link
Member

refs commented Sep 2, 2021

Hey @C0rby. A reference is just like a symbolic link and can be removed with the Remove operation.
When a share gets accepted, a new reference is created. When a share is declined the reference is removed with Remove operation. That is my understanding.

Hm, I was under the same impression

@C0rby
Copy link
Contributor Author

C0rby commented Sep 2, 2021

Ah, I see. Ok then I'll try to make cs3org/reva#1991 work with the Delete method. 👍

@C0rby
Copy link
Contributor Author

C0rby commented Sep 2, 2021

Ok, using the Delete method works. 👍

@C0rby C0rby closed this Sep 2, 2021
@C0rby C0rby deleted the remove-reference branch September 2, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants