Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox: Allow to specify the custom location to Firefox binary #45

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Firefox: Allow to specify the custom location to Firefox binary #45

merged 1 commit into from
Jun 12, 2024

Conversation

miry
Copy link
Contributor

@miry miry commented Mar 11, 2024 •
edited
Loading

Sample code:

capabilities = Selenium::Firefox::Capabilities.new
capabilities.firefox_options.args = [
  "--headless"
]
capabilities.firefox_options.binary = "/Applications/Firefox\ Developer\ Edition.app/Contents/MacOS/firefox"
driver.create_session(capabilities)

References: https://developer.mozilla.org/en-US/docs/Web/WebDriver/Capabilities/firefoxOptions

jwoertink
jwoertink approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Sorry for the late reply, I just realized I've never been getting notifications on this repo 😬

@jwoertink jwoertink merged commit ff301c5 into crystal-loot:master Jun 12, 2024
@miry miry deleted the firefox-bin branch June 12, 2024 14:41
jwoertink
jwoertink reviewed Jun 12, 2024
View reviewed changes
src/selenium/firefox/capabilities.cr
@@ -11,5 +11,6 @@ class Selenium::Firefox::Capabilities < Selenium::Capabilities
end

property args = [] of String
property binary String?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! I got so excited at having a PR, that I totally missed that this is a syntax error 🤦‍♂️

@jwoertink jwoertink mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miry @jwoertink