Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate non-blocking STDIN console on Windows #14947

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Aug 27, 2024

Resolves part of #14576. Thread::ConditionVariable is now used again.

There is no opt-out mechanism; while technically possible, there is probably no real benefit to it.

src/crystal/system/file_descriptor.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.14.0 milestone Sep 4, 2024
@straight-shoota straight-shoota merged commit 95af602 into crystal-lang:master Sep 5, 2024
59 of 61 checks passed
@HertzDevil HertzDevil deleted the feature/windows-stdin-non-blocking branch September 5, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants