Refactor Socket#system_receive to return Address
#14384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the interface and make it free of platform specifics in preparation of a bigger refactoring (crystal-lang#10766).
Sija
reviewed
Mar 22, 2024
Comment on lines
+91
to
+92
| bytes_read, address = system_receive(message) | ||
| {bytes_read, address.as(IPAddress)} |
There was a problem hiding this comment.
Could be shortened to, I think:
Suggested change
| bytes_read, address = system_receive(message) | |
| {bytes_read, address.as(IPAddress)} | |
| system_receive(message) |
There was a problem hiding this comment.
@Sija but system_receive returns an Address while we want an IPAddress here.
ysbaddaden
approved these changes
Mar 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal method
Socket#system_receivereturns the remote address in a platform-specific way, consisting of aLibC::Sockaddrpointer and the length of the address.I'm not sure what's the motivation behind that and I don't see a good reason. Returning a
Socket::Addressvalue directly leads to a cleaner API with native Crystal types only.This cleans up the interface and make it free of platform specifics in preparation of a bigger refactoring of the event loop (#10766).