Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #14369

Closed
wants to merge 1 commit into from
Closed

chore: fix some comments #14369

wants to merge 1 commit into from

Conversation

avoidaway
Copy link

No description provided.

@avoidaway
chore: fix some comments
62bbca0 
Signed-off-by: avoidaway <cmoman@126.com>
@HertzDevil
Copy link
Contributor

Only the duplicate to is relevant to the upstream markd; spec.txt no longer includes the offending paragraph, and the other typos are fixed in icyleaf/markd#47. In any case, we should be able to easily pick up any upstream changes after #14365 is applied.

@straight-shoota
Copy link
Member

straight-shoota commented Mar 18, 2024 •
edited
Loading

I overlooked that these changes are all in lib. That's vendored code. Let's not merge this here and instead update the dependency (after #14365 is merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avoidaway @HertzDevil @straight-shoota @ysbaddaden