Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pending_wasm32 #14086

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Add pending_wasm32 #14086

merged 3 commits into from
Dec 14, 2023

Conversation

HertzDevil
Copy link
Contributor

Similar to pending_win32, this allows us to disable some specs in a single file without having to skip all the other specs in that same file.

straight-shoota
straight-shoota requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removals of require "../../support/win32" seem unrelated to this change. I think they should go into a separate PR.

@straight-shoota straight-shoota added this to the 1.11.0 milestone Dec 13, 2023
@straight-shoota straight-shoota merged commit 63781fa into crystal-lang:master Dec 14, 2023
55 checks passed
@HertzDevil HertzDevil deleted the feature/pending_wasm32 branch December 15, 2023 11:12
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
1 task
@HertzDevil HertzDevil mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:specs platform:wasm topic:stdlib
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota