Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts/*.cr all executable #13999

Merged

Conversation

HertzDevil
Copy link
Contributor

Adds the execute permission bits and #!.

@straight-shoota
Copy link
Member

Some CI jobs are failing

@HertzDevil
Copy link
Contributor Author

make crystal shouldn't regenerate the data, both here and in #13998. Do you have an idea why this happens?

@HertzDevil
Copy link
Contributor Author

I am now quite sure that neither this nor #13998 caused the CI failures because it is now happening to entirely unrelated PRs: https://github.com/crystal-lang/crystal/actions/workflows/aarch64.yml

@straight-shoota
Copy link
Member

Let's discuss that CI bug in #14007

I suppose we can proceed with this then...

@straight-shoota straight-shoota added this to the 1.11.0 milestone Nov 22, 2023
@straight-shoota straight-shoota merged commit 0393e08 into crystal-lang:master Nov 23, 2023
52 of 55 checks passed
@HertzDevil HertzDevil deleted the refactor/script-executable branch November 24, 2023 07:22
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants