Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Skip spec execution on error exit #13986

Merged

Conversation

straight-shoota
Copy link
Member

Spec execution is triggered by an at_exit handler. This handler should not execute when the process is exiting due to a previous error.

Ref: #13763 (comment)

@straight-shoota straight-shoota added this to the 1.11.0 milestone Nov 20, 2023
@straight-shoota straight-shoota merged commit f8fafc3 into crystal-lang:master Nov 21, 2023
54 of 55 checks passed
@straight-shoota straight-shoota deleted the fix/skip-spec-on-error branch November 21, 2023 13:47
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@straight-shoota straight-shoota changed the title Fix skip spec execution on error exit Fix: Skip spec execution on error exit Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants