Fix FileUtils.ln_sf to override special file types
#13896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
changed the title
FileUtils.ln_sf to use File.delete?FileUtils.ln_sf to delete special file types
straight-shoota
changed the title
FileUtils.ln_sf to delete special file typesFileUtils.ln_sf to override special file types
HertzDevil
approved these changes
Oct 18, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation using
File.file?checks only if the destination is an ordinary file. But any kind of file should be deleted, regardless of its type. SoFile.exists?would be better suited here.Also, we need to use
rm_rfinstead ofFile.deletebecausedest_pathcan be a directory.