-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Unicode 15.1.0 #13812
Support Unicode 15.1.0 #13812
Conversation
Implementing GB9c seems non-trivial. It requires information which is currently unavailable in the break detection algorithm. I'm not sure how it could be integrated into the current implementation. |
@@ -61,7 +64,7 @@ File.open(path, "w") do |file| | |||
graphemes << string_or_char(grapheme.to_s) | |||
end | |||
|
|||
file.puts " it_iterates_graphemes #{string.dump}, [#{graphemes.join(", ", &.dump)}] # #{comment}" | |||
file.puts " #{%(pending "GB9c" { ) if pending} it_iterates_graphemes #{string.dump}, [#{graphemes.join(", ", &.dump)}] #{" }" if pending} # #{comment}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line became bit hard to read, it might be helpful to unpack it.
The grapheme break specs have roughly doubled in size and
are currently failingsome are now marked as pending due to the addition of rule GB9c to the list of grapheme cluster boundary rules in UAX29 Revision 43.cc @straight-shoota @naqvis