Skip to content

Commit

Permalink
Problem: default headerHashNum is too large (#539)
Browse files Browse the repository at this point in the history
* clean up

* Problem: default headerHashNum is too large
  • Loading branch information
mmsqe authored Oct 7, 2024
1 parent 853e1e5 commit 580ce6e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 17 deletions.
5 changes: 0 additions & 5 deletions x/evm/types/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,3 @@ func (m *MsgUpdateParams) ValidateBasic() error {

return m.Params.Validate()
}

// GetSignBytes implements the LegacyMsg interface.
func (m MsgUpdateParams) GetSignBytes() []byte {
return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(&m))
}
2 changes: 1 addition & 1 deletion x/evm/types/params.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var (
// DefaultEnableCall enables contract calls (i.e true)
DefaultEnableCall = true
// DefaultHeaderHashNum defines the default number of header hash to persist.
DefaultHeaderHashNum = uint64(10000)
DefaultHeaderHashNum = uint64(256)
)

// NewParams creates a new Params instance
Expand Down
11 changes: 0 additions & 11 deletions x/feemarket/types/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ import (

var _ sdk.Msg = &MsgUpdateParams{}

// GetSigners returns the expected signers for a MsgUpdateParams message.
func (m *MsgUpdateParams) GetSigners() []sdk.AccAddress {
addr := sdk.MustAccAddressFromBech32(m.Authority)
return []sdk.AccAddress{addr}
}

// ValidateBasic does a sanity check of the provided data
func (m *MsgUpdateParams) ValidateBasic() error {
if _, err := sdk.AccAddressFromBech32(m.Authority); err != nil {
Expand All @@ -21,8 +15,3 @@ func (m *MsgUpdateParams) ValidateBasic() error {

return m.Params.Validate()
}

// GetSignBytes implements the LegacyMsg interface.
func (m MsgUpdateParams) GetSignBytes() []byte {
return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(&m))
}

0 comments on commit 580ce6e

Please sign in to comment.