Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: latest memiavl is not integrated #993

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 23, 2023

Solution:

  • update memiavl deps

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update memiavl deps
@yihuang yihuang requested a review from a team as a code owner June 23, 2023 06:47
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #993 (7722e69) into master (7664c1f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   33.14%   33.16%   +0.02%     
==========================================
  Files         128      128              
  Lines       20023    20029       +6     
==========================================
+ Hits         6636     6642       +6     
  Misses      12329    12329              
  Partials     1058     1058              
Flag Coverage ฮ”
integration_tests 20.80% <100.00%> (+0.04%) โฌ†๏ธ
integration_tests_byzantine 9.65% <0.00%> (-0.01%) โฌ‡๏ธ
integration_tests_gov 10.09% <100.00%> (+0.02%) โฌ†๏ธ
integration_tests_grpc 10.07% <100.00%> (+0.02%) โฌ†๏ธ
integration_tests_ibc 24.77% <0.00%> (-0.01%) โฌ‡๏ธ
integration_tests_ledger 9.85% <0.00%> (-0.01%) โฌ‡๏ธ
integration_tests_slow 9.85% <0.00%> (-0.01%) โฌ‡๏ธ
integration_tests_solomachine 9.65% <0.00%> (-0.01%) โฌ‡๏ธ
integration_tests_upgrade 10.07% <100.00%> (+0.02%) โฌ†๏ธ
unit_tests 10.97% <0.00%> (-0.01%) โฌ‡๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage ฮ”
app/memiavl.go 100.00% <100.00%> (รธ)

@yihuang yihuang requested a review from mmsqe June 23, 2023 06:56
Copy link
Contributor

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might update install-nix-action to v22 now

@yihuang yihuang added this pull request to the merge queue Jun 23, 2023
Merged via the queue into crypto-org-chain:master with commit 836309b Jun 23, 2023
31 of 33 checks passed
@yihuang yihuang deleted the memiavl-integration branch June 23, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants