Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: update voting_period is not tested #1017

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 26, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.34%. Comparing base (c26a336) to head (2d7d581).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1017   +/-   ##
=======================================
  Coverage   34.34%   34.34%           
=======================================
  Files          93       93           
  Lines       14105    14105           
=======================================
  Hits         4844     4844           
  Misses       8319     8319           
  Partials      942      942           
Flag Coverage Δ
integration_tests 25.79% <ø> (ø)
integration_tests_byzantine 11.27% <ø> (ø)
integration_tests_gov 11.54% <ø> (ø)
integration_tests_grpc 11.54% <ø> (ø)
integration_tests_ibc 27.52% <ø> (ø)
integration_tests_ledger 11.53% <ø> (ø)
integration_tests_slow 11.53% <ø> (ø)
integration_tests_solomachine 11.32% <ø> (ø)
integration_tests_upgrade 11.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe marked this pull request as ready for review October 26, 2023 02:56
@mmsqe mmsqe requested a review from a team as a code owner October 26, 2023 02:56
mmsqe and others added 2 commits October 26, 2023 12:38
Signed-off-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
@mmsqe mmsqe enabled auto-merge August 15, 2024 09:14
@mmsqe mmsqe added this pull request to the merge queue Aug 15, 2024
Merged via the queue into crypto-org-chain:master with commit f26b2cc Aug 15, 2024
30 of 32 checks passed
mmsqe added a commit to kaz-CDC/chain-main that referenced this pull request Sep 6, 2024
* Problem: update voting_period is not tested

* Apply suggestions from code review

Signed-off-by: yihuang <huang@crypto.com>

* fix test

---------

Signed-off-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants