Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rules): touchups for Jackson serialization #301

Merged
merged 1 commit into from
Jan 8, 2024
Merged

chore(rules): touchups for Jackson serialization #301

merged 1 commit into from
Jan 8, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores mentioned this pull request Nov 20, 2023
Merged
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Nov 20, 2023
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Cryostat Test: At least one test failed ❌
https://github.com/cryostatio/cryostat-core/actions/runs/6934339280

@github-actions GitHub Actions
Copy link

Image does not exist! Please wait for the initial build and push to complete before using /build_test command.

@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-301-d6ac5a18099dd5d9b3b5601d9db1ce548067bc84-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-301-d6ac5a18099dd5d9b3b5601d9db1ce548067bc84-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-301-d6ac5a18099dd5d9b3b5601d9db1ce548067bc84-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-301-d6ac5a18099dd5d9b3b5601d9db1ce548067bc84-linux-arm64 sh smoketest.sh

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Cryostat Test: At least one test failed ❌
https://github.com/cryostatio/cryostat-core/actions/runs/6934498717

@github-actions GitHub Actions
Copy link

Image does not exist! Please wait for the initial build and push to complete before using /build_test command.

@andrewazores
Copy link
Member Author

Looks like https://github.com/cryostatio/cryostat/issues/1783 perhaps

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-301-d8189515889e7d2a2ae2e45e6f716b4e1837d9d2-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-301-d8189515889e7d2a2ae2e45e6f716b4e1837d9d2-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-301-d8189515889e7d2a2ae2e45e6f716b4e1837d9d2-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-301-d8189515889e7d2a2ae2e45e6f716b4e1837d9d2-linux-arm64 sh smoketest.sh

@andrewazores andrewazores marked this pull request as ready for review January 8, 2024 14:07
aali309
aali309 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 8f60aa2 into cryostatio:main Jan 8, 2024
13 checks passed
@andrewazores andrewazores deleted the rules-result-serialization branch January 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @aali309