-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device States and Backend Switching #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename `getType` member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Module: DX12 ❎
The issue involves the DX12 backend.
Module: Vulkan 🌋
The issue involves the Vulkan backend.
Priority: High
A high priority issue.
Type: Requirement
An implementation is required before the next release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR introduces several API improvements:
DeviceState
allows to let the device manage resources, namely render passes, pipelines, buffers, images, samplers and descriptor sets.Device state resources also can be assigned a name now, which is also a preparation for #15.
Related issues
ToDo
Currently, it is not possible to switch from DX12 back to Vulkan, since D3D12 only supports flip-model based swap chains and there is no way to reset the window afterwards. To fix this, the Vulkan swap chain should interop the DXGI swap chain if the DX12 backend is available. This should also improve performance for Vulkan, since it does not rely on legacy GDI bitblt anymore.
Also the readme and documentation should be adapted before merging.