Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CMakeSettings.json with CMakePresets.json. #64

Merged
merged 8 commits into from
Feb 28, 2022
Merged

Conversation

crud89
Copy link
Owner

@crud89 crud89 commented Feb 28, 2022

This replaces the Visual Studio specific CMakeSettings.json file with the platform independent CMakePresets.json file. Currently the preset version is fixed to 2 in order to keep supporting Visual Studio 2019, which only ships with CMake 3.20. This means that the installDir and toolchainFile fields are present (for higher versions), but the respective cache variables are also specified. We might later remove the cache variables.

@crud89 crud89 added Priority: Medium A issue with normal priority. Type: Requirement An implementation is required before the next release. Status: In Progress Module: Build 🛠 Issues that involve the build process. labels Feb 28, 2022
@crud89 crud89 added this to the Alpha #03 milestone Feb 28, 2022
@crud89 crud89 self-assigned this Feb 28, 2022
@crud89 crud89 marked this pull request as ready for review February 28, 2022 10:50
@crud89 crud89 modified the milestones: Alpha #03, Alpha #02 Patch 1 Feb 28, 2022
@crud89 crud89 merged commit 55a23b6 into main Feb 28, 2022
@crud89 crud89 deleted the cmake-presets branch March 2, 2022 08:07
@crud89 crud89 removed Status: In Progress Priority: Medium A issue with normal priority. labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Build 🛠 Issues that involve the build process. Type: Requirement An implementation is required before the next release.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant