-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken build issues #888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect #[cfg] attribute introduced in crossterm-rs#862 prevented compilation on unix
Looks like there's a few build failures in the current project that need to be cleared up. The CI makes it difficult to clear them up as a whole rather than one problem at a time due to failing at the first problem rather than failing multiple jobs in parallel. |
This was referenced May 5, 2024
Great -- my idea was to follow up too, thanks for the quick PR to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several issues were encountered after the merging of various PRs.
This was mostly caused by CI not being run on all of the PRs (I suspect
this was due to the GitHub first time repo contributor setting).
Fixes: #883
Fixes: #883
Supersedes: #887
Supersedes: #884