Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken build issues #888

Merged
merged 7 commits into from
May 5, 2024
Merged

fix: broken build issues #888

merged 7 commits into from
May 5, 2024

Conversation

joshka
Copy link
Collaborator

@joshka joshka commented May 5, 2024

Several issues were encountered after the merging of various PRs.
This was mostly caused by CI not being run on all of the PRs (I suspect
this was due to the GitHub first time repo contributor setting).

Fixes: #883
Fixes: #883
Supersedes: #887
Supersedes: #884

@joshka joshka requested a review from TimonPost as a code owner May 5, 2024 09:54
joshka added 2 commits May 5, 2024 02:57
An incorrect #[cfg] attribute introduced in crossterm-rs#862 prevented compilation on unix
@joshka
Copy link
Collaborator Author

joshka commented May 5, 2024

Looks like there's a few build failures in the current project that need to be cleared up. The CI makes it difficult to clear them up as a whole rather than one problem at a time due to failing at the first problem rather than failing multiple jobs in parallel.

@joshka joshka changed the title fix: incorrect cfg fix: broken build issues May 5, 2024
@joshka joshka mentioned this pull request May 5, 2024
@TimonPost TimonPost merged commit fce58c8 into crossterm-rs:master May 5, 2024
6 checks passed
@TimonPost
Copy link
Member

Great -- my idea was to follow up too, thanks for the quick PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build break from #862
3 participants