Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 3 #240

Merged
merged 11 commits into from
Sep 20, 2019
Merged

Cleanup 3 #240

merged 11 commits into from
Sep 20, 2019

Conversation

zrzka
Copy link
Contributor

@zrzka zrzka commented Sep 20, 2019

  • Not all tests were starting with the test_ prefix
  • It's not necessary to check for is_ok() in tests, simple unwrap() is enough
  • Some tests were rewritten
  • TerminalCursor::reset_position() renamed to restore_position()
    • I read reset_position as a set it to (0, 0) or something like this.
    • restore is much more clear.
  • Removed get_ prefixes from methods (not from functions)
  • Renamed ScreenBuffer::create() -> new()

Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
crossterm_cursor/src/cursor.rs Show resolved Hide resolved
crossterm_utils/src/functions.rs Show resolved Hide resolved
crossterm_winapi/src/screen_buffer.rs Outdated Show resolved Hide resolved
crossterm_cursor/src/sys/winapi.rs Show resolved Hide resolved
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
Signed-off-by: Robert Vojta <rvojta@me.com>
@TimonPost TimonPost merged commit 5216ecb into crossterm-rs:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants