This repository has been archived by the owner on Oct 22, 2019. It is now read-only.
to_alternate: Switch back to main screen if into_raw_mode fails #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
What is the motivation behind this change? |
|
I would guess cleanup? If I ask for alternate screen in raw mode and the function fails, I, as a user, do not want to end up in an inconsistent state like alternate & no raw. Which is not something I asked for. It should give me both or nothing. |
|
Right now if you run any Crossterm application that does |
|
I'd merge this one as it's really useful and make the API / behavior more consistent. |
|
Yea this is very useful, thanks for the explanation! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.