Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an introductory Upjet-based provider monitoring guide #181

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Mar 31, 2023

Description of your changes

This PR adds an introductory guide for monitoring the runtime of Upjet-based providers. It discusses in detail the custom Prometheus metrics we have within the Upjet runtime and shows examples of these metrics in action. There's also an account for the controller-runtime metrics and some further references to documentation.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

The metrics were introduced and tested here.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 009d7e2 into crossplane:main Mar 31, 2023
@ulucinar ulucinar deleted the monitor-md branch March 31, 2023 16:01
@hwinkel
Copy link

hwinkel commented Nov 9, 2023

What about adding OTEL Tracing to upjet to better trace the execution of the terraform modules and report back context aware infos and errors ?!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants