-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle sensitive input maps via SecretReference #138
Conversation
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you also drop a comment in regards to how many CRDs are affected by this change in the official providers and which ones would be breaking changes?
@muvaf no CRDs effected with this change since there were no configured resource with a sensitive input of type map since it was failing indeed. Double checked this by running make generate in all 3 providers consuming this change. |
Thanks @turkenh ! |
Description of your changes
This PR fixes the issues we are having with sensitive input fields of type map by using a
SecretReference
as the data type.Fixes #134
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Tested with
aws_glue_connection
resource and this PR using the below manifests: