Move common package linter functionality to crossplane-runtime #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultParser is not descriptive of the Parser implementation's purpose. PackageParser indicates the this parser is meant for parsing packages. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Downstream consumers may implement their own linter functions, but the core linter loop can be generalized, as well as helper functions such as Or. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Linter functionality has been implemented in
crossplane/crossplane, but the core linter loop and helper functions can be generalized for consumption by anyLinterimplementer. Passed___LinterFnthat depend oncrossplane/crossplanetypes will be kept inc/c, but will likely be moved in crossplane/crossplane#1795 to the newxpkgpkg, which is contains functionality for interacting with Crossplane packages.This PR also renames
DefaultParsertoPackageParser, which is technically a breaking API change, but we have not released since this was added and it won't break downstream consumers who only invokeparser.New()then deal with theParserinterface methods.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make testand the same functionality already exists inc/c