Fix enumeration warnings #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great - thanks! I've added a basic test for some of these publish warnings which I'll push after merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like a couple of things might be wrong with the enumeration warnings:
In order to address the first problem, I tried to centralize the logic that decides what clues actually get included in the puzzle, so that the enumeration warnings can use it too. I think it will be useful in #507 as well, and it's possible it could be shared by the "missing clues" publishing error.
However, I'd totally understand if the priority is just to get the warnings fixed and not risk any modifications to the (rather critical) publishing code!