Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl cannot be update to 1.2.0 yet #478

Closed
malbarbo opened this issue Oct 30, 2020 · 1 comment · Fixed by #485
Closed

musl cannot be update to 1.2.0 yet #478

malbarbo opened this issue Oct 30, 2020 · 1 comment · Fixed by #485

Comments

@malbarbo
Copy link
Contributor

musl was update to 1.2.0 in #452. The 1.2 changed the definition of time_t from 32 to 64bits, which can generate some compatibility issues (https://musl.libc.org/time64.html).

Considering that libc crate and the rust std library does not yet updated to 1.2.0 (rust-lang/libc#1848) and the problems that can arising by using musl 1.1.x together with 1.2.x, I think it's best to not update musl used in cross images.

CC @brainstorm @therealprof

@brainstorm
Copy link
Contributor

Good catch! IIRC In my experience introducing Musl 1.2.x in cross was the only way to get OpenSSL compiling in static, so it seems like we are in a crossroads here: openssl or rust-libc w/ time64, I hope they fix rust-libc soon so that openssl keeps compiling fine :/

asaaki added a commit to asaaki/rust-musl-cross that referenced this issue Mar 20, 2021
There are issues around time64 and similar types.

See:
- cross-rs/cross#478
- rust-lang/libc#1848
asaaki added a commit to asaaki/rust-musl-cross that referenced this issue Mar 20, 2021
There are issues around time64 and similar types.

See:
- cross-rs/cross#478
- rust-lang/libc#1848
bors bot added a commit that referenced this issue Jun 8, 2022
485: Downgrade musl to 1.1.24 r=otavio a=malbarbo

Fixes #478.

Co-authored-by: Marco A L Barbosa <malbarbo@gmail.com>
Co-authored-by: Alexander Huszagh <ahuszagh@gmail.com>
@bors bors bot closed this as completed in ce1548b Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants