Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro-entry.sh: remove hardcoded SDK release number #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WallaceIT
Copy link

Remove the hardcoded Poky SDK release number from the distro-entry.sh script, which will select automatically the environment setup script with the higher release version in its path.

Remove the hardcoded Poky SDK release number from the distro-entry.sh
script, which will select automatically the environment setup script
with the higher release version in its path.

Signed-off-by: Francesco Valla <valla.francesco@gmail.com>
@moto-timo
Copy link
Member

You are assuming that the Poky SDK is already installed on the host. This is not the case for the GitHub Actions build automation which creates these containers. The automation MUST continue to work with very little human intervention.

Please consider refactoring to allow a default value and an option to replace with a desired value on the command line instead.

For example
RELEASE="${RELEASE:-5.0}"

@WallaceIT
Copy link
Author

Hi,

distro-entry.sh is used as entrypoint inside the container, and at the moment is only activates the Poky SDK if a specific version (4.1) is found. The idea behind the PR is to make this mechanism generic and thus decouple from the SDK version that may be installed inside the base image (considering for example crops/poky images, this is true only for a subset of available images). This would allow to change the base image(s) - e.g. changing the SDK version - without impacting the functionality of this repo.

Given all this, I'm not sure I'm following the remark behind the Github Actions automation, as the proposed change shouldn't affect the way in which the build host works - but I'm not an expert in Github CI, so I may have missed something.

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants