New feature: can pause specific jobs upon startup #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetanotherion
approved these changes
Feb 19, 2020
| @@ -86,6 +90,10 @@ class CuttleProject private[cuttle] (val name: String, | |||
| if (paused) { | |||
| logger.info("Pausing workflow") | |||
| scheduler.pauseJobs(jobs.all, executor, xa)(Auth.User("Startup")) | |||
| } else { | |||
| val toPause = jobs.all.filter(j => j == jobsToBePausedOnStartup) | |||
| logger.info(s"Pausing ${toPause.map(j=> s"${j.name} (${j.id})")}") | |||
There was a problem hiding this comment.
OPT: keep the same ident (filter(j=>...) vs (map(j=>...)
brisssou
force-pushed
the
pausing_specific
branch
from
4758a60
to
238a644
Compare
yetanotherion
approved these changes
Feb 19, 2020
vguerci
reviewed
Feb 19, 2020
| @@ -86,6 +90,10 @@ class CuttleProject private[cuttle] (val name: String, | |||
| if (paused) { | |||
| logger.info("Pausing workflow") | |||
| scheduler.pauseJobs(jobs.all, executor, xa)(Auth.User("Startup")) | |||
| } else { | |||
| val toPause = jobs.all.filter(_ == jobsToBePausedOnStartup) | |||
There was a problem hiding this comment.
Unless mistaking you are comparing a Set[Job] with Job (_ == jobsToBePausedOnStartup), maybe jobs.intersect(jobsToBePausedOnStartup) or something like?
Thanks for your contribution :)
There was a problem hiding this comment.
you are very right 🤦♂
brisssou
force-pushed
the
pausing_specific
branch
2 times, most recently
from
91686ef
to
4b9f754
Compare
vguerci
reviewed
Feb 19, 2020
| @@ -86,6 +90,10 @@ class CuttleProject private[cuttle] (val name: String, | |||
| if (paused) { | |||
| logger.info("Pausing workflow") | |||
| scheduler.pauseJobs(jobs.all, executor, xa)(Auth.User("Startup")) | |||
| } else { | |||
| val toPause = jobs.all.intersect(jobsToBePausedOnStartup) | |||
| logger.info(s"Pausing ${toPause.map(j => s"${j.name} (${j.id})").mkString(" ")}") | |||
There was a problem hiding this comment.
Also maybe an if (toPause.nonEmpty) to prevent such logging with no jobs
brisssou
force-pushed
the
pausing_specific
branch
from
4b9f754
to
d06ce59
Compare
yetanotherion
approved these changes
Feb 19, 2020
timeseries/src/main/scala/com/criteo/cuttle/timeseries/CuttleProject.scala
Outdated
Show resolved
Hide resolved
brisssou
force-pushed
the
pausing_specific
branch
from
d06ce59
to
b6ebc46
Compare
yetanotherion
approved these changes
Feb 19, 2020
vguerci
approved these changes
Feb 19, 2020
scala-steward
pushed a commit
to scala-steward/cuttle
that referenced
this pull request
Feb 19, 2020
yetanotherion
pushed a commit
to yetanotherion/cuttle
that referenced
this pull request
Apr 6, 2020
yetanotherion
added a commit
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.