Generate structural type invariants #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidc
force-pushed
the
tyinv-gen
branch
10 times, most recently
from
19d419a
to
5825771
Compare
voidc
force-pushed
the
tyinv-gen
branch
2 times, most recently
from
e768e46
to
4e64e32
Compare
xldenis
reviewed
Jun 14, 2023
xldenis
reviewed
Jun 14, 2023
xldenis
reviewed
Jun 14, 2023
xldenis
reviewed
Jun 14, 2023
xldenis
reviewed
Jun 14, 2023
| let generics = ty_param_names(ctx.tcx, def_id).collect(); | ||
| (generics, subst) | ||
| } else if let DepNode::TyInv(ty) = dep { | ||
| let generics = TyInvKind::from_ty(ty).generics(ctx.tcx); |
xldenis
reviewed
Jun 14, 2023
| #[inline] | ||
| pub(crate) fn erase_regions(mut self, tcx: TyCtxt<'tcx>) -> Self { | ||
| match &mut self { | ||
| Dependency::Item(_, s) => *s = tcx.erase_regions(*s), |
There was a problem hiding this comment.
I wonder if you couldn't derive TypeFoldable for Dependency and get this for free?
xldenis
reviewed
Jun 14, 2023
|
A few nits about the code, and we've already talked about the remaining larger issues in mattermost. I think this is pretty much ready to merge as a first step though! |
xldenis
reviewed
Jun 14, 2023
xldenis
reviewed
Jun 14, 2023
| @@ -38,7 +38,7 @@ impl TyInvKind { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn to_ty<'tcx>(self, tcx: TyCtxt<'tcx>) -> Ty<'tcx> { | |||
| pub(crate) fn to_skeleton_ty<'tcx>(self, tcx: TyCtxt<'tcx>) -> Ty<'tcx> { | |||
There was a problem hiding this comment.
Can you remove pub(crate)?
There was a problem hiding this comment.
No, the function is used to build the self node in the clone map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes all the code for generating structural invariants but does not yet actually generate them when adding type invariants. This will be in a follow-up PR.