Prepare for Melpa #7
Conversation
@purcell from MELPA said: "Don't use your own major mode hook like this. Instead, provide a defcustom called something like "mint-format-on-save", and then add mint-format-on-save-maybe to before-save-hook. Note that I say before-save-hook, while you're currently using after-save-hook: mint-format-file wrongly assumes that every buffer will have an associated file, which is not true. mint-format-file should instead either copy the current buffer's contents to a temporary file, or you can use call-process-region/shell-command-on-region if mint format can read from STDIN."
Easier than a separate Package-Requires declaration for `seq`.
The former is the standard spelling in Emacs.
|
If you merge these, I'll send them the PR to add the package. This PR addresses:
|
|
@jgarte Can you give this a quick thumbs up/down when you have the time? It's all simple maintenance, apart from disabling the hook which MELPA asked for. |
@lassik Thanks for the contribution. Sorry for the delay. I merged your changes. Feel free to add the package to MELPA. That would be much appreciated. I also made a release for 1.0.3 and sent a package update to GNU Guix: https://issues.guix.gnu.org/57729 |
|
@lassik Would you like commit access to this repo to help with maintenance? |
|
@jgarte Thanks for the offer but I don't really use Mint. It's better if people who do maintain the Emacs package. |
|
@creatorrr @gdotdesign @jgarte This repo seems like the most complete Emacs package for Mint. Would you be willing to move it under the https://github.com/mint-lang organization? |
|
@lassik Not sure if that really is necessary since IIRC, most of the developers in that organization who have commit access are not using emacs but vscode and https://mint-lang.com/guide/getting-started/tools There's a vim mode mentioned in that link that is also not part of the mint organizations GitHub account and developed in their own forge space. |
No description provided.