[WIP] enable prettier to run automatically

[dijitali]

Fixes

• Fixes [Feature] enable Prettier to run automatically #520 by @dijitali

Description

Runs prettier automatically for consistency.

Technical details

• Adds Husky package which is the recommended method of setting up git hooks
• Upgrade to latest supports with Node version 14:
  • Husky v9 drops node v14 support
  • Prettier 3.0 drops node v14 support (docs says v14 is supported but I got a warning on npm install)
• Also ignores coverage and dist directories when running Prettier

Tests

TODO

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[netlify]

✅ Deploy Preview for creativecommons-chooser ready!

Name	Link
🔨 Latest commit	fb588b6
🔍 Latest deploy log	https://app.netlify.com/sites/creativecommons-chooser/deploys/6618b280d60c3c0008fbb608
😎 Deploy Preview	https://deploy-preview-522--creativecommons-chooser.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[dijitali]

Prettier docs specifically state that prettier should run after linters but I get a build error if it does:

⠴  Building for production...

 ERROR  Failed to compile with 2 errors                                                                     8:42:14 PM

 error  in ./src/components/Stepper.vue

Module Error (from ./node_modules/eslint-loader/index.js):

/app/src/components/Stepper.vue
   77:20  warning  Unexpected space before function parentheses   space-before-function-paren
  100:1   error    Expected indentation of 6 spaces but found 8   indent
  101:1   error    Expected indentation of 8 spaces but found 10  indent
  102:1   error    Expected indentation of 6 spaces but found 8   indent
...

I suspect the eslint-config-prettier config is not working as expected and/or something else needs upgrading.

[dijitali]

OK no, I think the conflict was specifically with eslint/prettier indentation rules. This goes away with 218b42a .

Now the remaining problem is stylelint falling over during the git hook...

[dijitali]

Closing in favour of #530.