Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "alt" attributes to generated HTML icon img elements #507

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Add "alt" attributes to generated HTML icon img elements #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3d78b9
Add null alt element to icon img in HTML output
dijitali Mar 27, 2024
e8d2cf2
Run project build
dijitali Mar 27, 2024
22b3a91
Merge branch 'main' into a11y/add-icon-img-alt
TimidRobot Apr 12, 2024
8f0b337
Merge branch 'main' into a11y/add-icon-img-alt
TimidRobot Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><meta name="viewport" content="width=device-width,initial-scale=1"><meta name="description" content="Want to license your work with Creative Commons, but not sure where to start, or which license is right for you? Use our license chooser!"><link rel="icon" href="/favicon.ico"><link rel="icon" type="image/png" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png" sizes="192x192"><link rel="apple-touch-icon-precomposed" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png"><meta name="twitter:card" content="summary"><meta name="twitter:site" content="@creativecommons"><meta name="twitter:creator" content="@creativecommons"><meta property="og:url" content="https://beta-chooser.creativecommons.org"><meta property="og:title" content="Choose a License"><meta property="og:type" content="website"><meta property="og:description" content="Want to license your work with Creative Commons, but not sure where to start, or which license is right for you? Use our license chooser!"><meta property="og:image" content="https://mirrors.creativecommons.org/presskit/logos/cc.logo.large.png"><meta property="og:locale" content="en_US"><meta property="og:locale:alternate" content="ru_RU"><title>Choose a License</title><link href="/css/chunk-87a74b80.493fcced.css" rel="prefetch"><link href="/js/chunk-87a74b80.6e5f111e.js" rel="prefetch"><link href="/css/app.2fdce638.css" rel="preload" as="style"><link href="/js/app.afe83491.js" rel="preload" as="script"><link href="/js/chunk-vendors.58f5ae05.js" rel="preload" as="script"><link href="/css/app.2fdce638.css" rel="stylesheet"></head><body><noscript><strong>We're sorry but License Chooser doesn't work properly without JavaScript enabled. Please enable it to continue.</strong></noscript><div id="app"></div><script src="/js/chunk-vendors.58f5ae05.js"></script><script src="/js/app.afe83491.js"></script></body></html>
<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><meta name="viewport" content="width=device-width,initial-scale=1"><meta name="description" content="Want to license your work with Creative Commons, but not sure where to start, or which license is right for you? Use our license chooser!"><link rel="icon" href="/favicon.ico"><link rel="icon" type="image/png" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png" sizes="192x192"><link rel="apple-touch-icon-precomposed" href="https://creativecommons.org/wp-content/uploads/2016/05/cc-site-icon-300x300.png"><meta name="twitter:card" content="summary"><meta name="twitter:site" content="@creativecommons"><meta name="twitter:creator" content="@creativecommons"><meta property="og:url" content="https://beta-chooser.creativecommons.org"><meta property="og:title" content="Choose a License"><meta property="og:type" content="website"><meta property="og:description" content="Want to license your work with Creative Commons, but not sure where to start, or which license is right for you? Use our license chooser!"><meta property="og:image" content="https://mirrors.creativecommons.org/presskit/logos/cc.logo.large.png"><meta property="og:locale" content="en_US"><meta property="og:locale:alternate" content="ru_RU"><title>Choose a License</title><link href="/css/chunk-87a74b80.493fcced.css" rel="prefetch"><link href="/js/chunk-87a74b80.6e5f111e.js" rel="prefetch"><link href="/css/app.2fdce638.css" rel="preload" as="style"><link href="/js/app.213f71ad.js" rel="preload" as="script"><link href="/js/chunk-vendors.58f5ae05.js" rel="preload" as="script"><link href="/css/app.2fdce638.css" rel="stylesheet"></head><body><noscript><strong>We're sorry but License Chooser doesn't work properly without JavaScript enabled. Please enable it to continue.</strong></noscript><div id="app"></div><script src="/js/chunk-vendors.58f5ae05.js"></script><script src="/js/app.213f71ad.js"></script></body></html>
2 changes: 2 additions & 0 deletions docs/js/app.213f71ad.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/js/app.afe83491.js.map → docs/js/app.213f71ad.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions docs/js/app.afe83491.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/utils/license-utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ function generateLicenseLink(licenseIcons, licenseUrl, licenseName) {
const iconSrc = attr =>
`${ICON_BASE_URL}/${attr.toLowerCase()}.svg${assetPathRef}`;
const icons = licenseIcons
.map(attr => `<img ${iconStyle} src="${iconSrc(attr)}">`)
.map(attr => `<img ${iconStyle} src="${iconSrc(attr)}" alt="">`)
TimidRobot marked this conversation as resolved.
Show resolved Hide resolved
.join('');

const linkHref = `href="${licenseUrl}${assetPathRef}"`;
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/specs/components/LicenseHTML.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ describe('LicenseHTML.vue', () => {

const licenseIcons = wrapper.findAll('img');
expect(licenseIcons.length).toBe(2);
// Icon img elements should have the following attributes: source, style and alt
dijitali marked this conversation as resolved.
Show resolved Hide resolved
const licenseIconsArray = licenseIcons.wrappers;
licenseIconsArray.forEach((img) => {
expect(Object.keys(img.attributes()).length).toBe(3);
});
});

it('has correct information when all attribution data is provided', async () => {
Expand Down Expand Up @@ -96,5 +101,10 @@ describe('LicenseHTML.vue', () => {

const licenseIcons = wrapper.findAll('img');
expect(licenseIcons.length).toBe(2);
// Icon img elements should have the following attributes: source, style and alt
const licenseIconsArray = licenseIcons.wrappers;
licenseIconsArray.forEach((img) => {
expect(Object.keys(img.attributes()).length).toBe(3);
});
});
});