Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #386 - Removed useless dependency to reduce build size #468

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

Cronus1007
Copy link
Member

Fixes

Fixes #386 by @brylie

Description

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Cronus1007 Cronus1007 requested review from a team as code owners March 22, 2023 14:57
@Cronus1007 Cronus1007 requested review from annatuma, possumbilities and akmadian and removed request for a team March 22, 2023 14:57
@Cronus1007 Cronus1007 changed the title removed useless dependency Issue #386 - Removed useless dependency to reduce build size Mar 22, 2023
@Cronus1007
Copy link
Member Author

@possumbilities Could you please have a look at the build of this branch?

@Cronus1007 Cronus1007 marked this pull request as draft March 22, 2023 15:01
@Cronus1007 Cronus1007 marked this pull request as ready for review March 24, 2023 13:32
@Cronus1007
Copy link
Member Author

@possumbilities Any leads related to this PR?

Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cronus1007 Thanks for this (and apologies for the late reply), I tested it locally and everything seems to build and function as expected.

Approved!

@possumbilities possumbilities self-assigned this Jun 23, 2023
@possumbilities possumbilities merged commit 3afbed5 into main Jun 23, 2023
@possumbilities possumbilities deleted the issue-386 branch June 23, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit code and reduce build size
2 participants