Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to Vue 3.x #356

Open
brylie opened this issue Jun 3, 2021 · 8 comments
Open

Upgrade project to Vue 3.x #356

brylie opened this issue Jun 3, 2021 · 8 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@brylie
Copy link
Contributor

brylie commented Jun 3, 2021

Blocked by: cc-archive/vocabulary-components#8

Vue 3.0 was released in September 2020. However, this project is still using Vue 2.x.

Decide when it is time to upgrade this project to Vue 3.x

Description

One of the design constraints of Vue 3.x was to preserve backward compatibility with Vue 2.x projects. This would ideally mean very little would need to change when the Chooser project upgrades to Vue 3.x.

Alternatives

We can stay at 2.x, but that would mean decreasing support as 2.x reaches end-of-life.

Additional context

The upcoming Vue 3.1 release includes a "Migration Build" to help projects transition from 2.x to 3.x.

The Vue User Guide is defaulting to 3.x to signal that projects should be targeting the 3.x release.

⚠️ Vue 3.x drops support for IE 11

@brylie brylie added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Jun 3, 2021
@obulat
Copy link
Contributor

obulat commented Jun 3, 2021

Very exciting change! :)

@TimidRobot TimidRobot added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jun 28, 2021
@sadn1ck
Copy link
Contributor

sadn1ck commented Sep 6, 2021

(new here, 👋🏽)So, I was having a look at this locally, and I might be wrong, but wouldn't Vocabulary also need to be updated to vue 3 for chooser to be able to use the components from there? (v-radio, v-button, etc)

PS: I was able to get the build running on vue 3 but there were a lot of errors with component resolution, v-button css issues and i18n issues (vue-i18n v8 is for vue2 and v9 is for vue3)

@brylie
Copy link
Contributor Author

brylie commented Sep 7, 2021

@sadn1ck good point! 😃

I've created an upstream issue to upgrade to Vue 3.x, which will enable this issue to move forward.

By the way, are you available to help with some Vue development? We have a pull request underway to simplify the repository structure of the CC Vocabulary monorepo and need a few more changes to make sure all of the components will render.

@sadn1ck
Copy link
Contributor

sadn1ck commented Sep 7, 2021

Yep @brylie! I'd love to help out. I'm not familiar with storybook right now, so I'll have a look and start working on it as soon as I can.

@brylie
Copy link
Contributor Author

brylie commented Sep 7, 2021

OK, great! I think there is a basic pattern to follow to fix the remaining components. I will @ mention you on the related thread so we can pick up the conversation there. For what it's worth, I think we should finish the "simplify the project structure using Vue CLI" task before considering the Vue 3 upgrade. What do you think?

@sadn1ck
Copy link
Contributor

sadn1ck commented Sep 7, 2021

Yep! Let's complete that first. That way we can focus on one thing at a time.

@ImaJin14
Copy link

ImaJin14 commented Mar 6, 2023

hi @TimidRobot and @possumbilities this issue is said to be blocked in #356 (comment) so are we going to have to resolve the later before continuing with this one??

@possumbilities
Copy link
Contributor

@ImaJin14 likely, but there is a larger refactor of Vocabulary happening that will likely result in correcting this issue downstream. Going to put this as blocked ti denote that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: Backlog
Development

No branches or pull requests

6 participants