Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvments #76

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Some improvments #76

wants to merge 9 commits into from

Conversation

thib3113
Copy link

@thib3113 thib3113 commented Aug 23, 2024

Hi, I've done some improvments to this docker image .

  • allow multiple accounts
  • allow nearly all configurations from msmtp (works on all tested configurations)
  • allow accounts to inherit from others
  • allow to ask authentication on msmtpd
  • don't write password to configuration file, keep it in secret

I keep the script backward compatible (and so I forbide some accounts names), it will add a deprecated message, and migrate the configuration to the account default


Some notes :

  • multiple accounts allow to deploy the same container for multiple applications
  • all configurations can fix issue Add environment variable for logfile for msmtp #53 because you can now set SMTP_<account>_LOGFILE=/var/log/msmtp
  • inherit is usefull because account choice is based on the From header on the email ( -f %F par in the command from msmtpd ), so you can create one configuration, and inherit with multiple from
  • authentication on msmtpd => allow to protect the endpoint, without giving a password to all of our apps
  • don't write password => msmtp allow to pass a function to get the password, so, allowing to cat the docker secrets, without copying the password on another file

@thib3113 thib3113 marked this pull request as ready for review August 23, 2024 01:17
@thib3113 thib3113 marked this pull request as draft August 23, 2024 01:19
@thib3113 thib3113 marked this pull request as ready for review August 23, 2024 08:10
@thib3113
Copy link
Author

thib3113 commented Sep 2, 2024

Ping @crazy-max ? If you have some time for a feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant