NG: Finetune footer spacing #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
reviewed
Aug 8, 2024
| {%- if display_version %} | ||
| {%- if versions %} |
There was a problem hiding this comment.
FYI: We are also discussing this change over here.
There was a problem hiding this comment.
When adjusting into that direction, the version chooser may re-appear on other projects where we wanted to hide it? Shall we just bake a new devX release including your updates, in order to just try it out?
There was a problem hiding this comment.
@amotl I've renamed it back, lets test it
msbt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This should
bring back the version chooser and alsofix some spacing issues.Preview
https://crate-docs-theme--518.org.readthedocs.build/en/518/