Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong initialization of Analyzer filter in CAnalyzerPage due to a typo #289

Closed
MarkusHeiling opened this issue Mar 2, 2016 · 0 comments
Closed

Comments

@MarkusHeiling
Copy link

There is a typo in "CAnalyzerPage::OnApplyChanges" which is using a wrong define to initialize the capture configuration of the analyzer filter. This may lead to that the analyzer filter does not capture any samples if the capture options are changed with the checkboxes of that dialog.

HRESULT CAnalyzerPage::OnApplyChanges()
{
    UpdateData();
    filter->put_Enabled(IsDlgButtonChecked(IDC_ANALYZER_ENABLED) ? VARIANT_TRUE : VARIANT_FALSE);
    ASSERT(m_nPreviewByteCount <= 0xFFFF);
    filter->put_PreviewSampleByteCount((unsigned short) m_nPreviewByteCount);

    int captureConfig = SCF_ALL; // <-- Should be "SCF_All" (lowercase "l" characters)

Please note the "SCF_ALL" define (uppercase "L" characters), it does not map to the supposed define "SCF_All" (lowercase "L" characters) from "StatisticCaptureFlags".

Another small typo is in "CAnalyzerPage::GetEntryString()".

case SRK_BF_Run: val = _T("IBaseFilter:Run:"); break;
should read as
case SRK_BF_Run: val = _T("IBaseFilter::Run"); break;

Kind regards

@MarkusHeiling MarkusHeiling changed the title Wrong initialization of Analyer filter in CAnalyzerPage due to a typo Wrong initialization of Analyzer filter in CAnalyzerPage due to a typo Mar 2, 2016
cplussharp added a commit that referenced this issue Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants