Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI overhaul #96

Merged
merged 9 commits into from
Oct 23, 2023
Merged

CLI overhaul #96

merged 9 commits into from
Oct 23, 2023

Conversation

vivi
Copy link
Contributor

@vivi vivi commented Oct 23, 2023

Addresses #11.

  • runs black formatter on main.py (should be another PR 🤫)
  • uses questionary in lieu of flags (still supports flags as a legacy)
  • introduces configuration files that are saved to disk and loaded in
  • asks user if they want to autoload saved agent file (if exists)
  • asks user if they want to regenerate embeddings
  • no longer relies on readline

cli-overhaul

@vivi vivi requested a review from cpacker October 23, 2023 05:52
@cpacker
Copy link
Owner

cpacker commented Oct 23, 2023

Comments:

  • Can we reorganize the personas in the selection list? Maybe put sam_pov first, then memgpt_starter, etc (basically sam_pov first, and memgpt_doc not first)
  • At the user selection, should be "Which user" not "Which persona"
  • Can we put a note that the user can create their own personas and users by adding text files inside the selection box?
  • Can we put "Warning - you are running MemGPT with X" above "Running ..."? So two pink things are together

@cpacker
Copy link
Owner

cpacker commented Oct 23, 2023

Also should we sauce up the [exit by typing /exit] message? It's so sad and grey next to its multicolor friends.

Copy link
Owner

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@vivi vivi merged commit 0a782fc into main Oct 23, 2023
@cpacker cpacker deleted the cli-overhaul branch October 23, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants