fix: read embedding_model and embedding_dim from embedding_config #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahwooders
changed the title
sarahwooders
approved these changes
Jul 31, 2024
No problem! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Fix a bug with the
memgpt list sourcesCLI command.How to test
In a fresh project, you can load a simple data source and run
memgpt list sourceswhich should break withAttributeError: 'SourceModel' object has no attribute 'embedding_dim'. Did you mean: 'embedding_config'?Have you tested this PR?
Yes. Tested this change using
Related issues or PRs
#1587