fix: Await full sync stop before closing the app #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When closing the application from a user request (via the "Quit" button for example), we first stop the synchronization to avoid corrupting data. However, we were not waiting for the synchronization to be fully stopped (i.e. it is an asynchronous process) before closing the application. We believe this might be the source of crashes on Windows.
taratatach
added a commit
that referenced
this pull request
May 9, 2023
This reverts commit 0901d11. By awaiting the full sync stop, we prevent quitting the app during a synchronisation or a watcher run while these can take a very long time (especially the first scan of local and remote changes). We'll bring back this behavior once we have a way to cancel the on-going sync and watch runs.
taratatach
added a commit
that referenced
this pull request
May 9, 2023
) This reverts commit 0901d11. By awaiting the full sync stop, we prevent quitting the app during a synchronisation or a watcher run while these can take a very long time (especially the first scan of local and remote changes). We'll bring back this behavior once we have a way to cancel the on-going sync and watch runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing the application from a user request (via the "Quit"
button for example), we first stop the synchronization to avoid
corrupting data.
However, we were not waiting for the synchronization to be fully
stopped (i.e. it is an asynchronous process) before closing the
application.
We believe this might be the source of crashes on Windows.
Please make sure the following boxes are checked: