Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Burmese translation and locales #483

Merged
merged 2 commits into from
Jan 15, 2022

Conversation

brootware
Copy link
Contributor

@brootware brootware commented Jan 14, 2022

Description

Added a burmese language translation yml file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/deploy.sh --dry-run (at the root of the project) locally and passed
  • I have tested this feature in the browser
  • Not applicable

Test Configuration

  • Browser type & version:
  • Operating system:
  • Ruby version:
  • Bundler version:
  • Jekyll version:
  • Not applicable

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation! I'm not familiar with Burmese, I can find my in the IOS language table, but not my-MY. The closest I can find so far is ms-MY, but it's in Malay. So are you sure that my-MY is correct? If you are not sure, could you consider changing it from my-MY to my?

@digitigradeit
Copy link

The closest I can find so far is ms-MY, but it's in Malay. So are you sure that my-MY is correct? If you are not sure, could you consider changing it from my-MY to my?

https://lh.2xlibre.net/locale/my_MM/
https://www.localeplanet.com/icu/iso639.html#my

The correct locale for Burmese Myanmar is my_MM: my - Burmese, MM - Burmese Myanmar

ms is Malaysaian

@brootware
Copy link
Contributor Author

Thank you @digitigradeit and @cotes2020 , will push a new commit soon to rename the file.

Copy link
Contributor Author

@brootware brootware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed file name to my-MM

@cotes2020 cotes2020 merged commit b8c3ea2 into cotes2020:master Jan 15, 2022
@cotes2020 cotes2020 added this to the 5.1.0 milestone Jan 15, 2022
@brootware brootware deleted the add-burmese-language branch January 17, 2022 01:33
linkliu pushed a commit to linkliu/game-tech-post-old that referenced this pull request Apr 10, 2022
dkbnz pushed a commit to dkbnz/jekyll-theme-chirpy that referenced this pull request Jul 12, 2022
shihtiy-tw pushed a commit to shihtiy-tw/shihtiy-tw.github.io that referenced this pull request Nov 26, 2022
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Jan 9, 2023
Ap3x pushed a commit to Ap3x/ap3x.github.com that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants