fix: return error if branch not found in child order #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
commented
Aug 29, 2024
go/proof.go
Outdated
| } | ||
| } | ||
| panic(fmt.Errorf("branch %d not found in order %v", branch, order)) | ||
|
|
||
| return 0, fmt.Errorf("branch %d not found in order %v", branch, order) |
There was a problem hiding this comment.
This is basically the change needed. The rest of changes are for bubbling the error up.
There was a problem hiding this comment.
Alternatively I could have just swallowed the error in the call sites of getPosition and return in those places the default value (false, and 0s). I thought of bubbling the error up in case we ever do #29.
crodriguezvega
commented
Aug 29, 2024
go/proof.go
Outdated
| if branch < 0 || int(branch) >= len(order) { | ||
| panic(fmt.Errorf("invalid branch: %d", branch)) | ||
| return 0, fmt.Errorf("invalid branch: %d", branch) |
There was a problem hiding this comment.
I also converted this one into a regular error instead of panicking.
crodriguezvega
commented
Aug 29, 2024
| idx, err := orderFromPadding(spec, op) | ||
| if err != nil { | ||
| return false | ||
| return false, err |
There was a problem hiding this comment.
Here an error that previously was swallowed can now be returned.
crodriguezvega
commented
Aug 29, 2024
go/proof.go
Outdated
| idx, err := orderFromPadding(spec, op) | ||
| if err != nil { | ||
| return false | ||
| return false, nil |
There was a problem hiding this comment.
Another one that previously was swallowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.