Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tmclient update header validation for v0.44.x #917

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Oct 12, 2023

Closes: #911 but on v0.44.x release

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy self-assigned this Oct 12, 2023
@rnbguy rnbguy marked this pull request as ready for review October 12, 2023 12:41
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5a79491) 71.49% compared to head (f87ef0a) 71.65%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.44.x     #917      +/-   ##
===================================================
+ Coverage            71.49%   71.65%   +0.15%     
===================================================
  Files                  124      124              
  Lines                14960    15035      +75     
===================================================
+ Hits                 10696    10773      +77     
+ Misses                4264     4262       -2     
Files Coverage Δ
crates/ibc/src/clients/ics07_tendermint/header.rs 72.68% <ø> (+1.11%) ⬆️
...ibc/src/core/ics02_client/handler/update_client.rs 95.49% <100.00%> (+0.04%) ⬆️
...ates/ibc/src/core/ics04_channel/acknowledgement.rs 78.51% <ø> (ø)
crates/ibc/src/mock/context.rs 75.44% <92.98%> (+0.88%) ⬆️
crates/ibc/src/mock/host.rs 91.72% <86.20%> (-1.54%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @rnbguy!

@Farhad-Shabani Farhad-Shabani merged commit edb76a9 into release/v0.44.x Oct 12, 2023
13 checks passed
@Farhad-Shabani Farhad-Shabani deleted the v0.44.x/rano/fix-tmclient-update-header-validation branch October 12, 2023 16:12
Farhad-Shabani added a commit that referenced this pull request Oct 12, 2023
* fix: tmclient update header validation for v0.44.x (#917)

* test for tmclient update with different validator sets

* fix doc lints

* rm incorrect check

* add changelog entry

* chore: prep v0.44.2 release (#918)

---------

Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* fix: tmclient update header validation for v0.44.x (#917)

* test for tmclient update with different validator sets

* fix doc lints

* rm incorrect check

* add changelog entry

* chore: prep v0.44.2 release (#918)

---------

Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants