Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: header validation during tendermint client update #912

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix: header validation during tendermint client update #912

merged 4 commits into from
Oct 11, 2023

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Oct 11, 2023 •
edited
Loading

Closes: #911

Description

Removes the incorrect validation check at Header::validate_basic.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy linked an issue Oct 11, 2023 that may be closed by this pull request
Incorrect header validation during tendermint client update #911
Closed
@rnbguy rnbguy self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a2d10f1) 67.40% compared to head (7c91b75) 67.54%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
+ Coverage   67.40%   67.54%   +0.13%     
==========================================
  Files         131      131              
  Lines       16026    16105      +79     
==========================================
+ Hits        10803    10878      +75     
- Misses       5223     5227       +4
Files Coverage Δ
crates/ibc/src/clients/ics07_tendermint/header.rs 72.68% <ø> (+1.11%) ⬆️
...ibc/src/core/ics02_client/handler/update_client.rs 95.45% <100.00%> (+0.04%) ⬆️
crates/ibc/src/mock/context.rs 75.79% <92.98%> (+0.85%) ⬆️
crates/ibc/src/mock/host.rs 91.60% <85.18%> (-1.67%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy marked this pull request as ready for review October 11, 2023 14:25
@rnbguy
Copy link
Collaborator Author

rnbguy commented Oct 11, 2023

@Farhad-Shabani I finalized the PR. I added the test in first commit as it shows failure and then success in final commit.

Farhad-Shabani
Farhad-Shabani approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌🏻

@Farhad-Shabani Farhad-Shabani merged commit fd472b8 into main Oct 11, 2023
13 checks passed
@Farhad-Shabani Farhad-Shabani deleted the rano/fix-header-validation-in-tmclient-update branch October 11, 2023 18:37
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
@rnbguy
fix: header validation during tendermint client update (#912)
f7a6a34 
* add reproducible test

* fix doc lints

* rm incorrect validation check

* changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farhad-Shabani Farhad-Shabani Farhad-Shabani approved these changes

Assignees

@rnbguy rnbguy

Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect header validation during tendermint client update
2 participants
@rnbguy @Farhad-Shabani