Add borsh derive for MsgTransfer
#845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
+ Coverage 71.47% 71.55% +0.08%
==========================================
Files 124 124
Lines 14983 15044 +61
==========================================
+ Hits 10709 10765 +56
- Misses 4274 4279 +5
☔ View full report in Codecov by Sentry. |
Comment on lines
+55
to
+60
| if bytes_read != 32 { | ||
| return Err(borsh::maybestd::io::Error::new( | ||
| borsh::maybestd::io::ErrorKind::InvalidInput, | ||
| format!("Expected to read 32 bytes, read {bytes_read}"), | ||
| )); | ||
| } |
There was a problem hiding this comment.
Since the `buf`` is of fixed 32 size, would this error ever occur?
There was a problem hiding this comment.
Yes, if somehow we read less than 32 bytes
Farhad-Shabani
approved these changes
Aug 30, 2023
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* add borsh derive for `MsgTransfer` * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.