Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make token transfer events compatible with latest ibc-go #618

Merged
merged 9 commits into from
Apr 20, 2023
Merged

Make token transfer events compatible with latest ibc-go #618

merged 9 commits into from
Apr 20, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Apr 13, 2023

Closes: #495

Description

Only remaining field missing is memo, which will be added with #559.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 60.60% and project coverage change: +0.02 🎉

Comparison is base (8ed4655) 72.97% compared to head (05c42b2) 73.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   72.97%   73.00%   +0.02%     
==========================================
  Files         125      125              
  Lines       15646    15663      +17     
==========================================
+ Hits        11417    11434      +17     
  Misses       4229     4229
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/context.rs 50.82% <0.00%> (-0.25%) ⬇️
crates/ibc/src/applications/transfer/events.rs 17.30% <54.16%> (+8.97%) ⬆️
...c/src/applications/transfer/relay/send_transfer.rs 95.55% <100.00%> (+0.13%) ⬆️
crates/ibc/src/events.rs 20.54% <100.00%> (+1.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Farhad-Shabani
Farhad-Shabani reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question; in some places, there is a difference in how many events we emit compared to how many IBC-go emits (like here & here). Does that have a specific reason?

@plafer
Copy link
Contributor Author

plafer commented Apr 14, 2023

For the first link (sendTransfer callback), we indeed forgot to output the message event type. I will fix this.

The second link you shared (OnAcknowledgement callback) emits the same 2 events as ibc-rs (see here), unless I'm mistaken.

@Farhad-Shabani
Copy link
Member

The second link you shared (OnAcknowledgement callback) emits the same 2 events as ibc-rs (see here), unless I'm mistaken.

Ahh, right, this one is correct

@plafer plafer added the A: blocked Admin: blocked by another (internal/external) issue or PR label Apr 14, 2023
@plafer
Copy link
Contributor Author

plafer commented Apr 14, 2023

Blocked on #623

@plafer plafer removed the A: blocked Admin: blocked by another (internal/external) issue or PR label Apr 20, 2023
@plafer
Copy link
Contributor Author

plafer commented Apr 20, 2023

@Farhad-Shabani this is now ready for review!

Farhad-Shabani
Farhad-Shabani approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@Farhad-Shabani Farhad-Shabani merged commit 9bb6327 into main Apr 20, 2023
@Farhad-Shabani Farhad-Shabani deleted the plafer/495-transfer-events branch April 20, 2023 14:32
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
@plafer
Make token transfer events compatible with latest ibc-go (#618)
c2ea41f 
* add `module` event where needed

* remove unused `module_name`

* add sender event field

* cleanup

* TransferEvent

* changelog

* add missing event emission in send_transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farhad-Shabani Farhad-Shabani Farhad-Shabani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make token transfer events fully compatible with latest ibc-go
2 participants
@plafer @Farhad-Shabani