Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix demon parity scale encoding enabled #577

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Mar 29, 2023

Closes: #N/A

Description

Allow to store prefixed denom in Substrate storage and used in extrinsic (transaction instructions) to allow configuration for specified denoms and prefixes.


PR author checklist:

  • Added changelog entry, using unclog.
  • No need to test, I just have built with relevant feature.
  • No GH issue, but issues and pulls share same incremental id, so used it.
  • Actually some of stuff had already borsch and all had serde, so it was trivial, no need docs.
  • @hu55a1n1

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@dzmitry-lahoda dzmitry-lahoda marked this pull request as draft March 29, 2023 10:02
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review March 29, 2023 10:09
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (ffae7ea) 73.03% compared to head (c6ca0e0) 72.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   73.03%   72.94%   -0.10%     
==========================================
  Files         126      126              
  Lines       15681    15701      +20     
==========================================
  Hits        11453    11453              
- Misses       4228     4248      +20     
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/denom.rs 77.29% <0.00%> (-6.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plafer plafer merged commit 346dd3d into cosmos:main Mar 29, 2023
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* prefix demon parity scale encoding enabled

* release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants