Emit message events #564
Merged
Emit message events #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 72.70% 73.02% +0.32%
==========================================
Files 126 126
Lines 15550 15679 +129
==========================================
+ Hits 11306 11450 +144
+ Misses 4244 4229 -15
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
plafer
reviewed
Mar 23, 2023
plafer
reviewed
Mar 23, 2023
plafer
reviewed
Mar 23, 2023
plafer
suggested changes
Mar 24, 2023
crates/ibc/src/events.rs
Outdated
Comment on lines
207
to
210
| impl TryFrom<IbcEventType> for abci::Event { | ||
| type Error = Error; | ||
|
|
||
| fn try_from(event_type: IbcEventType) -> Result<Self, Self::Error> { |
There was a problem hiding this comment.
I find this unintuitive since it's not immediately clear to me that the map IbcEventType -> abci::Event yields a message abci Event. Can we instead make this a function
fn try_message_event_from_event_type(event_type: IbcEventType) -> Result<abci::Event, Error> { ... }`
This was referenced Mar 27, 2023
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* emit message events * add changelog * for clippy * remove ClientMisbehaviourMessage * add try_message_event_from_event_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #563
Description
Each execution handler emits a message event for the IBC handling according to https://github.com/cosmos/ibc-go/blob/main/docs/ibc/events.md#sendpacket-application-module-call
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.