Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add into_inner() for ICS07 ConsensusState #1156

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Apr 5, 2024

Description

  • Adds an into_inner() method for the ICS07 ConsensusState, so that dependent projects won't need to perform redundant cloning.
  • Removes redundant cloning within the IC07 check_substitute implementation.

PR author checklist:

  • Added changelog entry, using unclog.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.84%. Comparing base (d4c3655) to head (c579628).

Files Patch % Lines
...ts/ics07-tendermint/src/client_state/validation.rs 0.00% 6 Missing ⚠️
...bc-clients/ics07-tendermint/src/consensus_state.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   63.85%   63.84%   -0.01%     
==========================================
  Files         219      219              
  Lines       21359    21362       +3     
==========================================
  Hits        13638    13638              
- Misses       7721     7724       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani added this to the 0.52.0 milestone Apr 5, 2024
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just a question about the removed playground link.

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 1f581fa Apr 5, 2024
18 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/into-inner-for-tm-cons-state branch April 5, 2024 18:12
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* chore: add into_inner() for TmConsensusState + remove redundant cloning in check_substitute

* fix: markdown-lint-check

* chore: add unclog

* nit

* fix: revert adr007 playground
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants