imp: avoid unnecessary clones and validations when creating ClientId #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce ClientType::get_client_id method which constructs a new ClientId but forgoes client type verification. The client type has already been verified at creation and the verification guarantees that formatted ClientId will also be valid. Furthermore, rewrite ClientId::new so that it doesn’t take ownership of the client type and doesn’t allocated temporary strings. Furthermore, since ClinetType::get_client_id is now a thing, change the client type argument to be `&str` so that constructing ids from string client type is easier.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 70.90% 70.93% +0.03%
==========================================
Files 178 178
Lines 17995 17983 -12
==========================================
- Hits 12759 12756 -3
+ Misses 5236 5227 -9 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
requested changes
Dec 21, 2023
.changelog/unreleased/breaking-changes/1014-better-client-id-new.md
Outdated
Show resolved
Hide resolved
…ew.md Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
…1015) * imp: avoid unnecessary clones and validations when creating ClientId Introduce ClientType::get_client_id method which constructs a new ClientId but forgoes client type verification. The client type has already been verified at creation and the verification guarantees that formatted ClientId will also be valid. Furthermore, rewrite ClientId::new so that it doesn’t take ownership of the client type and doesn’t allocated temporary strings. Furthermore, since ClinetType::get_client_id is now a thing, change the client type argument to be `&str` so that constructing ids from string client type is easier. * wip * clippy * Update .changelog/unreleased/breaking-changes/1014-better-client-id-new.md Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com> Signed-off-by: Michal Nazarewicz <mina86@mina86.com> * build_client_id * drop variant * Update 1014-better-client-id-new.md Signed-off-by: Michal Nazarewicz <mina86@mina86.com> --------- Signed-off-by: Michal Nazarewicz <mina86@mina86.com> Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce ClientType::get_client_id method which constructs a new
ClientId but forgoes client type verification. The client type has
already been verified at creation and the verification guarantees that
formatted ClientId will also be valid.
Furthermore, rewrite ClientId::new so that it doesn’t take ownership
of the client type and doesn’t allocated temporary strings.
Furthermore, since ClinetType::get_client_id is now a thing, change
the client type argument to be
&strso that constructing ids fromstring client type is easier.
Closes: #1014
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.